fix(hmr): don't consider CSS dep as a circular dep #15229
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: hmr
p3-minor-bug
|
|
|
The real long term solutions is Tailwind moving out of PostCSS and integrating with bundlers like unoccs does, so I'm fine with this change |
sapphi-red
deleted the
fix/hmr-do-not-consider-css-dep-as-circular-dep
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In future, maybe we should add
cssImportersfield toModuleNodetype which will resolve these tailwind related issues together including #9512. But that will be a big change, so instead I made a small change that would fix the case that was working in past.fixes #15221
refs #14867
refs 6eaec3a
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).